#993 closed defect (fixed)

Compiling error with gcc 5.2.1 and Werror

Reported by: gsemmler Owned by: dmisev
Priority: minor Milestone:
Component: conversion Version: development
Keywords: Cc:
Complexity: Medium

Description

convertor.cc: In static member function ‘static
r_Convertor::convert_type_e r_Convertor::get_internal_type(const
r_Type*, bool)’:
convertor.cc:255:46: error: logical not is only applied to the left
hand side of comparison [-Werror=logical-not-parentheses]

if (!(*iter).type_of().type_id() == r_Type::CHAR

3)

bands


convertor.cc:255:46: error: comparison of constant ‘8’ with boolean
expression is always false [-Werror=bool-compare]

Change History (2)

comment:1 Changed 19 months ago by dmisev

Your patch did not apply:

+ git apply --check testpatch.patch
error: patch failed: conversion/png.cc:308
error: conversion/png.cc: patch does not apply
+ rm testpatch.patch
+ exit 1

I'd suggest you to just integrate it in your memory leaks patch with git rebase.

comment:2 Changed 16 months ago by dmisev

  • Resolution set to fixed
  • Status changed from new to closed

I think this was fixed.

Note: See TracTickets for help on using tickets.