Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#743 closed defect (fixed)

Do not set any default nodata value

Reported by: dmisev Owned by: uadhikari
Priority: major Milestone: 9.0.x
Component: qlparser Version: development
Keywords: Cc: pbaumann, pcampalani, jpass, mase
Complexity: Trivial

Description

The encode function sets by default nodata=0 to the output image. This is probably a bad idea and should be removed.

Systemtest oracles will need to be updated as well, or better yet, queries in the systemtest should be updated with explicit nodata=0.

Ticket spawn from #741

Change History (5)

comment:1 Changed 3 years ago by mase

  • Cc mase added

comment:2 Changed 3 years ago by dmisev

  • Owner changed from dmisev to uadhikari
  • Status changed from new to assigned

The source code that should be fixed is source:qlparser/qtencode.cc

In source:systemtest use

grep -R ' encode(' *

to find all testcases that use encode, and add a third parameter "nodata=0", if not present already. Make sure that the testcases_services are running and petascope is deployed beforehand.

comment:4 Changed 3 years ago by uadhikari

  • Resolution set to fixed
  • Status changed from assigned to closed

comment:5 Changed 3 years ago by dmisev

I submitted additional patch to fix the WCS oracles.

Note: See TracTickets for help on using tickets.