Opened 3 years ago

Closed 3 years ago

#593 closed defect (fixed)

WCPS not case sensitive on some keywords

Reported by: pcampalani Owned by: bthapaliya
Priority: major Milestone: 9.0.x
Component: petascope Version: development
Keywords: case sensitivity metadataexpr Cc: mantovani@…, vmerticariu, mdumitru
Complexity: Easy

Description

Despite the correct grammar definition in petascope.wcps.grammar.wcps.g, some WCPS keywords are case-sensitive:

for c in (eobstest) return crsset(c) -> Invalid coverage Expression, next node: crsset
for c in (eobstest) return crsSet(c) -> OK

for c in (eobstest) return ideNTifier(c) -> Invalid coverage Expression, next node: ideNTifier
for c in (eobstest) return ideNTifier(c) -> OK

This is apparently affecting metadata expressions only, but I did not make an exhaustive test.

for c in (eobstest) return encode(
-  add (c[Lat(0), Long(51)])
+  aDd (c[Lat(0), Long(51)])
, "csv")

-> OK

Case-sensitivity to all keywords should be evaluated, and test(s) added.

Change History (5)

comment:1 Changed 3 years ago by dmisev

There is most probably an equals test somewhere in the WCPS code itself, rather than in the parser.

comment:2 Changed 3 years ago by pcampalani

Yes exactly, this ticket must be all about some replacement of equals to .equalsIgnoreCase.

comment:3 Changed 3 years ago by pcampalani

  • Cc vmerticariu mdumitru added

comment:4 Changed 3 years ago by dmisev

  • Milestone changed from Future to 9.0.x
  • Owner changed from pcampalani to bthapaliya
  • Status changed from new to assigned

comment:5 Changed 3 years ago by bthapaliya

  • Resolution set to fixed
  • Status changed from assigned to closed

patch submited.
changeset:0ca548

Note: See TracTickets for help on using tickets.