Opened 3 years ago

Closed 2 years ago

#554 closed enhancement (fixed)

Add XML, SOAP and REST tests in WCS systemtests

Reported by: pcampalani Owned by: mdumitru
Priority: major Milestone: 9.0.x
Component: systemtest Version: development
Keywords: wcs xml soap rest tests Cc: pbaumann, dmisev, mdumitru
Complexity: Medium

Description

Currently there are only KVP test queries.

We should add equivalent XML, SOAP and REST protocol queries for each of the existing queries.

The oracle should be just one for the three queries, to make it more robust.

Each new WCS test query should be in the three formats as well.

Change History (11)

comment:1 Changed 3 years ago by pcampalani

  • Status changed from new to accepted

I'll take this for XML and SOAP.
Alex, afterwards can you add the REST queries?

comment:2 Changed 3 years ago by pcampalani

  • Owner changed from pcampalani to mdumitru
  • Status changed from accepted to assigned

XML tests added in changeset:cde6ccf.

Alex, I'm passing on this to you for the .rest queries, no need to tell you why.
(I do not see a critical urgency here for this).

No need for new oracles: now they do not have the protocol extension suffix (e.g. .kvp) since they are unique for the equivalent input queries, independently of their protocol.

comment:3 Changed 3 years ago by dmisev

I will file one more patch under this ticket: marking tests as known to fail. This is done by putting a file known_fails in the test directory, and adding each failing query in one line of the file. The systemtest then automatically considers these queries and marks them in the output as skipped instead of as fail.

comment:4 Changed 3 years ago by abeccati

Consider also updating the test system doc page with the known_fails concept

comment:6 Changed 3 years ago by pbaumann

note that REST is purely experimental currently, there is not even a complete OGC spec doc.

comment:7 Changed 3 years ago by dmisev

I know we have for REST and XML, not sure about SOAP? Is it planned to add it, or should we close the ticket already?

comment:8 Changed 3 years ago by pbaumann

SOAP is officially supported so at least a few tests needed (Jin does the rigorous OGC compliance test development so might do this at some time), REST is experimental ( andWCS REST spec is still under discussion, see comment above).

comment:9 Changed 3 years ago by pcampalani

While REST is experimental, if we provide an endpoint for that then we really should include it in the systemtests.

Regarding SOAP, I suggest not to add any tests query, while defining a template for SOAP requests, and filling the body with the existing .xml tests. Otherwise we land in a hell of tests duplication.

Regarding SOAP again: rigorous compliance is not too rigorous since maybe half of XML POST and SOAP tests are TBD in the WCS 2.0 test suite.

comment:10 Changed 3 years ago by pbaumann

SOAP: an OGC ETS is supposed to come from the DREAM project this year. In fact, as SOAP uses XML data like POST it should indeed not test the XML payload, but only the SOAP conformance (header/body envelope etc).

for REST there is no complete OGC specification, just a draft. So unclear what to test. The wiki documentation should state clearly that this is a first attempt, used to propose & discuss concepts in OGC, but neither comprehensive nor tested.

Last edited 3 years ago by pbaumann (previous) (diff)

comment:11 Changed 2 years ago by dmisev

  • Resolution set to fixed
  • Status changed from assigned to closed

We have kvp and xml now, and from the discussion it follows that it doesn't make sense to add rest/soap, so closing.

Note: See TracTickets for help on using tickets.