Opened 4 years ago

Closed 4 years ago

#229 closed enhancement (fixed)

Include git commit id in rasdaman's version

Reported by: dmisev Owned by: arezaeim
Priority: major Milestone: 8.4
Component: build system Version: 8.3
Keywords: Cc: pbaumann, abeccati
Complexity:

Description

When executing a rasql query, or rasdaman is started, the rasdaman version is logged. This version is taken from the RMANVERSION variable in configure.ac. The better way is to get the version info from the output of git describe, which may look like:

v8.3.1-155-g3b96b03

which gives both the version (v8.3.1) as well as the first 8 chars of the git commit id (g3b96b03), which may be useful to determine if certain patches have been included in the currently compiled binaries for example. So in configure.ac RMANVERSION should be set to the output of git describe, but without the commit number (155), i.e. it should be (v8.3.1-g3b96b03).

Traditionally RMANVERSION has been an integer, e.g. 8310 for 8.3.1, and in the code it's been divided by 1000 in many places in order to determine the version. This should be fixed, as the above would change the type of RMANVERSION to string. The change is mainly to remove any division and other arithmetic involved with RMANVERSION.

I've already submitted patch for this, but it got lost in the meantime so this should be redone.

Change History (7)

comment:1 Changed 4 years ago by arezaeim

  • Owner changed from dmisev to arezaeim
  • Status changed from new to assigned

comment:2 Changed 4 years ago by arezaeim

  • Resolution set to fixed
  • Status changed from assigned to closed

comment:3 Changed 4 years ago by dmisev

  • Resolution fixed deleted
  • Status changed from closed to reopened

We need to include the commit id in petascope as well, so that petascope logs it along with the other startup information.

comment:4 Changed 4 years ago by dmisev

  • Cc abeccati added

comment:5 Changed 4 years ago by abeccati

A clean way of managing builds for releases would be to tag them and use only the tags to build binaries to be distributed. Numeric (dotted) versions also enable dependency verification according to semantic versioning rules.
Lets keep this into consideration while laying out release policy

comment:6 Changed 4 years ago by dmisev

Alan this is about embedding the git commit id into the binary and is not related to releases. The case for petascope was brought up by Damiano comment:20:ticket:133

comment:7 Changed 4 years ago by pbaumann

  • Resolution set to fixed
  • Status changed from reopened to closed
Note: See TracTickets for help on using tickets.