#1071 closed defect (fixed)

rasj.jar is not installed on make install

Reported by: dmisev Owned by: bphamhuu
Priority: major Milestone: 9.1.x
Component: java Version: development
Keywords: Cc:
Complexity: Medium

Description (last modified by dmisev)

rasj.jar should be installed to $RMANHOME/lib

Attachments (1)

0001-rasj.jar-is-not-installed-on-make-install.patch (179.4 KB) - added by bphamhuu 17 months ago.

Download all attachments as: .zip

Change History (13)

comment:1 Changed 17 months ago by bphamhuu

Hey George,

Someone has added "applications/petascope/lib/rasj.jar" to ./gitignore

It should be added in petascope/lib/rasj.jar or when I open Petascope by Netbeans, it will have error with import class from org.odmg and rasj.

Do you mind if I upload this patch? (this has removed rasj.jar from gitignore).

http://www.rasdaman.org/attachment/ticket/1071/0001-rasj.jar-is-not-installed-on-make-install.patch

Last edited 17 months ago by bphamhuu (previous) (diff)

comment:2 follow-up: Changed 17 months ago by gmerticariu

Adding rasj in petascope dependencies is bad practice, since rasj is compiled differently for rnp and rasnet. The correct solution for this one is to put "java" folder as subdir for petascope. This way, "java" will be compiled before petascope and rasj.jar will be copied in the dependency list.

Add this line in Makefile.am in petascope and the issue will be fixed:

SUBDIRS=../../java

Last edited 17 months ago by gmerticariu (previous) (diff)

comment:3 in reply to: ↑ 2 ; follow-up: Changed 17 months ago by dmisev

Replying to gmerticariu:

The correct solution for this one is to put "java" folder as subdir for petascope.

I think you should be more specific, you mean subdir in the Makefile.am SUBDIRS right?

comment:4 follow-up: Changed 17 months ago by dmisev

This ticket is about installing rasj.jar into $RMANHOME/lib for example.

comment:5 Changed 17 months ago by dmisev

@Bang - rasj.jar has been added to .gitignore exactly because it shouldn't be pre-generated into the lib dir of petascope.

comment:6 Changed 17 months ago by bphamhuu

@Dimitar: year, I could understand from George's answer (as I don't know the reason before). What I would want to say here is for example: when clone new code, I could open project and doing instead of make or make install as it needs dependencies.

So as George said he could put "java" (this is a bit of confusing directory name) to Petascope properties then it does not complain with error when import.

comment:7 in reply to: ↑ 3 Changed 17 months ago by gmerticariu

Replying to dmisev:

Replying to gmerticariu:

The correct solution for this one is to put "java" folder as subdir for petascope.

I think you should be more specific, you mean subdir in the Makefile.am SUBDIRS right?

Yes, I put the command in my first comment.

comment:8 in reply to: ↑ 4 Changed 17 months ago by gmerticariu

Replying to dmisev:

This ticket is about installing rasj.jar into $RMANHOME/lib for example.

Is this a requirement? For rasj to be installed in the lib dir?

comment:9 Changed 17 months ago by dmisev

I don't know if it should be installed in the lib dir, or if there's some other standard installation place? But we need to distribute it somehow with RPMs for example, it's a library for Java clients.

comment:10 Changed 16 months ago by dmisev

  • Description modified (diff)
  • Owner changed from gmerticariu to bphamhuuIt
  • Status changed from new to assigned

comment:11 Changed 16 months ago by dmisev

  • Owner changed from bphamhuuIt to bphamhuu

comment:12 Changed 16 months ago by bphamhuu

  • Resolution set to fixed
  • Status changed from assigned to closed

Close ticket here as patch was accepted, thanks.

Note: See TracTickets for help on using tickets.